make _create_from_dict more resilient #1929
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext[]" and ["text[]"] for datatype
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
dirkkul
reviewed
Jan 26, 2026
| config = config.copy() | ||
| properties = [] | ||
| for prop in config["properties"]: | ||
| prop = prop.copy() |
Collaborator
There was a problem hiding this comment.
I think you can skip the copy
| self, | ||
| config: dict, | ||
| ) -> Union[Collection, Awaitable[CollectionAsync]]: | ||
| # Support both "name" and "class" fields for backward compatibility |
Collaborator
There was a problem hiding this comment.
If I understand it right, this is becasue the TS client provides a different output? Is that correct? If yes, could you update the comment?
| assert config.properties[0].data_type == DataType.TEXT | ||
|
|
||
| # Clean up | ||
| client.collections.delete(collection_name_3) |
Collaborator
There was a problem hiding this comment.
this needs a testcanse for the "name" - you could also parametrice our test to make it more readable, check for example test_replication_config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now accepts
{"name": "ExampleSchema"}or{"class": "ExampleSchema"}as well as
"dataType": "text[]", or"dataType": ["text[]"]